fix: AdvancedProfiler no longer crashes when stop() is called after teardown#21790
Open
pooyanazad wants to merge 3 commits into
Open
fix: AdvancedProfiler no longer crashes when stop() is called after teardown#21790pooyanazad wants to merge 3 commits into
pooyanazad wants to merge 3 commits into
Conversation
pooyanazad
requested review from
ethanwharris,
justusschock and
tchaton
as code owners
for more information, see https://pre-commit.ci
Author
|
Hi, we need a reviewer here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug where
AdvancedProfilercrashes with aValueErrorif a profiling context manager is active during trainer teardown.When
teardown()is called, it clears theprofiled_actionsdictionary. Exiting the context manager subsequently callsstop(), which was crashing because the action no longer existed.I fixed this by:
stop()return silently if the action doesn't exist.cProfileinstances inteardown()before clearing the dictionary to prevent global profiler leaks.Fixes #9136
Before submitting
test_profiler.py.PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist